From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO6U4-00013O-H0
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 10:19:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO6Tz-0001Ik-2w
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 10:19:44 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58818 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO6Ty-0001IV-LB
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 10:19:38 -0400
Message-ID: <5321BE78.7050306@suse.de>
Date: Thu, 13 Mar 2014 15:19:36 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1394720249-13318-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1394720249-13318-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun"
	warnings for qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org

Am 13.03.2014 15:17, schrieb Peter Maydell:
> When running under qtest we don't actually have any vcpu threads
> to be starved, so the warning about the I/O thread spinning isn't
> relevant, and the way qtest manipulates the simulated clock means
> the warning is produced a lot as a false positive. Suppress it if
> qtest_enabled(), so 'make check' output is less noisy.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  main-loop.c         |  3 ++-
>  stubs/Makefile.objs |  1 +
>  stubs/qtest.c       | 14 ++++++++++++++
>  3 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 stubs/qtest.c

Looks OK to me, a bit unfortunate that we need a stub, but

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg