From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOAwk-0001eY-Uw
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 15:05:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOAwg-0000cF-3K
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 15:05:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30970)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOAwf-0000bz-SM
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 15:05:34 -0400
Message-ID: <53220179.9090908@redhat.com>
Date: Thu, 13 Mar 2014 15:05:29 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <1394707572-15112-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA-qn5v76_p6449_OTum1CVeDrLhU7E0E3CkH+YvvugBQQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-qn5v76_p6449_OTum1CVeDrLhU7E0E3CkH+YvvugBQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 0/7] gtk: cleanups and fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 03/13/2014 02:55 PM, Peter Maydell wrote:
> On 13 March 2014 10:46, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>   Hi,
>>
>> Looks like I've became the default victim for gtk patches, with anthon=
y
>> being busy and /me recently picking up the gtk mouse wheel patch.
>>
>> So here is a collection of gtk patches hitting my inbox over the last
>> few days.  Not strictly bugfixes-only, but the cleanups are simple
>> enouth that I think they are fine for 2.0.
>>
>> please pull,
>>   Gerd
>>
>> The following changes since commit 239618707637ec87eba8c452d2b2f75dc5c=
a20c7:
>>
>>   Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2=
014-03-11 19:39:17 +0000)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.kraxel.org/qemu tags/pull-gtk-1
>>
>> for you to fetch changes up to 1962744467ec5624bfecb55bf5a2c321744da25=
3:
>>
>>   gtk: Don't warp absolute pointer (2014-03-13 10:12:47 +0100)
>=20
> Doesn't build, sorry:
>=20
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c: In function =E2=80=98gd=
_vc_init=E2=80=99:
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: implicit
> declaration of function =E2=80=98gtk_scrollable_get_vadjustment=E2=80=99
> [-Werror=3Dimplicit-function-declaration]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: nested
> extern declaration of =E2=80=98gtk_scrollable_get_vadjustment=E2=80=99
> [-Werror=3Dnested-externs]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: implicit
> declaration of function =E2=80=98GTK_SCROLLABLE=E2=80=99
> [-Werror=3Dimplicit-function-declaration]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: nested
> extern declaration of =E2=80=98GTK_SCROLLABLE=E2=80=99 [-Werror=3Dneste=
d-externs]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:17: error:
> assignment makes pointer from integer without a cast [-Werror]
> cc1: all warnings being treated as errors
> make: *** [ui/gtk.o] Error 1
>=20

Hmm, gtkscrollable is gtk3 only, I'll test building against gtk2 and resp=
in.
Sorry for the run around.

- Cole