From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOCQ7-0006R0-CZ for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:40:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOCQ2-0007Dy-31 for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:40:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38991 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOCQ1-0007Ds-T5 for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:39:58 -0400 Message-ID: <5322179A.8030506@suse.de> Date: Thu, 13 Mar 2014 21:39:54 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1394720249-13318-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1394720249-13318-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , patches@linaro.org Am 13.03.2014 15:17, schrieb Peter Maydell: > When running under qtest we don't actually have any vcpu threads > to be starved, so the warning about the I/O thread spinning isn't > relevant, and the way qtest manipulates the simulated clock means > the warning is produced a lot as a false positive. Suppress it if > qtest_enabled(), so 'make check' output is less noisy. >=20 > Signed-off-by: Peter Maydell [...] > diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs > index df3aa7a..6f06fca 100644 > --- a/stubs/Makefile.objs > +++ b/stubs/Makefile.objs > @@ -28,3 +28,4 @@ stub-obj-y +=3D vmstate.o > stub-obj-$(CONFIG_WIN32) +=3D fd-register.o > stub-obj-y +=3D cpus.o > stub-obj-y +=3D kvm.o > +stub-obj-y +=3D qtest.o [snip] Please note that the stubs are supposed to be sorted alphabetically. I'm still seeing two instances of the warning for i386 and x86_64 each. But it's a clear improvement. Thanks, applying to qom-next (with Makefile tweaked): https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg