From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOeB-0002Br-4q for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:43:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOOe6-00040D-60 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:43:22 -0400 Received: from mailapp01.imgtec.com ([195.89.28.114]:60079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOe5-0003zC-W7 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:43:18 -0400 Message-ID: <5322CF34.2020002@imgtec.com> Date: Fri, 14 Mar 2014 09:43:16 +0000 From: James Hogan MIME-Version: 1.0 References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kvm-devel , Gleb Natapov , QEMU Developers , Sanjay Lal , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Aurelien Jarno On 13/03/14 22:35, Peter Maydell wrote: > On 13 March 2014 21:28, Andreas F=C3=A4rber wrote: >> I'm not sure if we have a policy about __u64 etc. in KVM code. Since >> it'll be Linux-only I don't see problems currently; for cross-platform >> parts we prefer uint64_t. Suggest to leave as is unless told otherwise= . >=20 > For ARM I took the view that __u64 were the kernel's types, not > ours. The kernel header structs define fields as __u64 but for > in-QEMU functions and variables we should use the posix uint64_t. Thanks, I'll follow that way then. Cheers James