From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WOQCq-0002uz-1s
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:23:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WOQCh-0003By-LS
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:23:16 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:34123)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WOQCh-0003Bk-Dm
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:23:07 -0400
Received: by mail-ee0-f48.google.com with SMTP id b57so590663eek.7
	for <qemu-devel@nongnu.org>; Fri, 14 Mar 2014 04:23:05 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5322E695.7000702@redhat.com>
Date: Fri, 14 Mar 2014 12:23:01 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394148857-19607-1-git-send-email-agraf@suse.de>
	<1394148857-19607-74-git-send-email-agraf@suse.de>
In-Reply-To: <1394148857-19607-74-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 073/130] Add Enhanced Three-Speed Ethernet
	Controller (eTSEC)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Fabien Chouteau <chouteau@adacore.com>
Cc: Peter Maydell <peter.maydell@linaro.org>

Il 07/03/2014 00:33, Alexander Graf ha scritto:
> +                if (bd.flags | BD_INTERRUPT) {
> +                    /* Set RXFx */
> +                    etsec->regs[RSTAT].value |= 1 << (7 - ring_nbr);
> +
> +                    /* Set IEVENT */
> +                    ievent_set(etsec, IEVENT_RXF);
> +                }
> +
> +            } else {
> +                if (bd.flags | BD_INTERRUPT) {
> +                    /* Set IEVENT */
> +                    ievent_set(etsec, IEVENT_RXB);
> +                }
> +            }

Coverity flags this "bd.flags | BD_INTERRUPT" idiom... What did you 
mean?  Can you send a fix to qemu-trivial?

Paolo