From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOQqG-0002sN-ML
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:04:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOQqA-00006A-Ib
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:04:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36186)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WOQqA-00005V-9n
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:03:54 -0400
Message-ID: <5322F026.10203@redhat.com>
Date: Fri, 14 Mar 2014 08:03:50 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <cover.1394738819.git.crobinso@redhat.com>
	<1394790493.5732.5.camel@nilsson.home.kraxel.org>
In-Reply-To: <1394790493.5732.5.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On 03/14/2014 05:48 AM, Gerd Hoffmann wrote:
> On Do, 2014-03-13 at 15:30 -0400, Cole Robinson wrote:
>> First patch documents a configure option.
>> Next 3 patches fix deprecation warnings on gtk 3.10.
>> The remaining patches are bug fixes.
>>
>> v2:
>>     Add configure patch
>>     Fix building against GTK2
>=20
> I'll go cherry-pick the two warp bugfixes (patches 6+7) for qemu 2.0.
>=20
> I'll leave the other cleanups for 2.1.  The gtk2/3 compatibility isn't
> that easy to get right it seems.  Our current mimimal required gtk
> version is 2.18, and on rhel6 (2.20) the build still fails:
>=20
>   CC    ui/gtk.o
> In file included from /usr/include/gtk-2.0/gtk/gtk.h:233,
>                  from ui/gtk.c:48:
> /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function
> declaration isn=E2=80=99t a prototype
> ui/gtk.c: In function =E2=80=98gd_create_menu_machine=E2=80=99:
> ui/gtk.c:1308: error: =E2=80=98GDK_KEY_q=E2=80=99 undeclared (first use=
 in this
> function)
> ui/gtk.c:1308: error: (Each undeclared identifier is reported only once
> ui/gtk.c:1308: error: for each function it appears in.)
> make: *** [ui/gtk.o] Error 1
>=20

Hmm, thanks for testing. I didn't notice the GDK_KEY_foo back compat defi=
nes
at the top of gtk.c, we need one for GDK_KEY_q as well.

Would you prefer I wait until after 2.0 is out to resubmit the series?

- Cole