From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORHh-0004ch-PI for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:32:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WORHc-0000qE-Rs for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:32:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORHc-0000qA-7G for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:32:16 -0400 Message-ID: <5322F6CC.3000206@redhat.com> Date: Fri, 14 Mar 2014 06:32:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394605864-32237-1-git-send-email-famz@redhat.com> <1394605864-32237-3-git-send-email-famz@redhat.com> <20140313132657.GB4534@irqsave.net> <20140314071810.GB11745@T430.nay.redhat.com> In-Reply-To: <20140314071810.GB11745@T430.nay.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="smt4eUFBaEtw1dJGulcNUWWo1mRRJ0p1G" Subject: Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --smt4eUFBaEtw1dJGulcNUWWo1mRRJ0p1G Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/14/2014 01:18 AM, Fam Zheng wrote: >>> =20 >>> +void qmp_dirty_bitmap_add(const char *device, const char *name, >> Do we want this to work on node-names too ? >=20 > I think having dirty bitmap on device is good enough for now. If there = is a > necessity we can add on top. How would anything other than the active image ever be dirty? If only the active image can be written, then having it only operate on device name is fine, because there is no point in using any node name other than the one of the active layer, but that has a device name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --smt4eUFBaEtw1dJGulcNUWWo1mRRJ0p1G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTIvbMAAoJEKeha0olJ0NqZv8H/iu2vI0RygahAD+Pm3xubzfs Wmw2Add0VObmCRxS3XuE9C3cQmD4BIVFNn/j/zJECgNmItOnZvgU4/TKth8xQd/9 PmtTyqbCmyBmgTSmpXvRIrsRH0g5hlGZS2g646uhlsf/oIHGtoz4K+sD2gKv9aP2 TBulD6dLvRZGw3eAGuSOk5masU9l7VamUrCuzhHcd2zTT/YdQstf9pLtAtSInv0h 3Kke/xNQYloqRyrUVvvd2nZplxTNMRg4Z8ZWcF52y9+cTyzrfJW4TYzh8v4tCOck LtkWarfpAROHcmPh/uvP4q8Avej5yBOr/X6LAKC42y/e1hxIDkKg8SQkP/bkC0A= =AoBz -----END PGP SIGNATURE----- --smt4eUFBaEtw1dJGulcNUWWo1mRRJ0p1G--