From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORLb-0008Jt-9j for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WORLW-0002MS-CZ for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:36:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORLW-0002MJ-4F for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:36:18 -0400 Message-ID: <5322F7BD.2060605@redhat.com> Date: Fri, 14 Mar 2014 06:36:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394798814-21279-1-git-send-email-mrezanin@redhat.com> In-Reply-To: <1394798814-21279-1-git-send-email-mrezanin@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hGVevI3XHcrfPJbpSX0FJbwoi0Dul0ojM" Subject: Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrezanin@redhat.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hGVevI3XHcrfPJbpSX0FJbwoi0Dul0ojM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/14/2014 06:06 AM, mrezanin@redhat.com wrote: > From: Miroslav Rezanina >=20 > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support required machine type yet (the version > user downgraded to have to have this patch applied too, of course). >=20 > Signed-off-by: Miroslav Rezanina > --- > v7: > - use -machine instead of -M in error help message > - rebase to commit 0056ae2 >=20 > v6: > - print help instead of list supported machines on error > --- > vl.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) >=20 > + error_report("Unsupported machine type"); > + printf("\nUse -machine help to list supported machines!\n"); I might have used "Use '-machine help' to" to offset what the user is supposed to type, but I can live with what you have. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hGVevI3XHcrfPJbpSX0FJbwoi0Dul0ojM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTIve9AAoJEKeha0olJ0NqbGoH/icTzLYDz2efhCpR85XNBjoQ 5vSaAD5STENa5SEk1U5ls1UEXXhPs2EHPqWt9UlEe9UPh2tM+4i+fLHovBkMcSfx 8Da5le81kEGAcIwIr9BIegrmWzZoMsmsF2IesulStv92WOHpXXUKqGzoSmzjjCPD z9u4hZfiSIci8AkAzlnSujB6zv1Rxl2BHRj6EMXjWrAizzi6qspMHyLPijEC8+0V VtsGu61snCAY8zxtv2U+WjkXxklhUJPMfoU3jk0mQ6j2uQU205I5F3cOkMtfTy1t bDMZAQx3KE9rACGzc6XUvdEiU24nTzUmsgPIbZMKDrhtUUXEj6mkTapGPlmwwno= =26Wn -----END PGP SIGNATURE----- --hGVevI3XHcrfPJbpSX0FJbwoi0Dul0ojM--