From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORcx-00068V-Pz for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:54:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WORcr-0007lU-R4 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:54:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WORcr-0007lN-J8 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 08:54:13 -0400 Message-ID: <5322FBD0.1000206@redhat.com> Date: Fri, 14 Mar 2014 13:53:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= Cc: James Hogan , kvm-devel , Gleb Natapov , QEMU Developers , Sanjay Lal , Aurelien Jarno Il 13/03/2014 23:35, Peter Maydell ha scritto: >> > I'm not sure if we have a policy about __u64 etc. in KVM code. Since >> > it'll be Linux-only I don't see problems currently; for cross-platform >> > parts we prefer uint64_t. Suggest to leave as is unless told otherwise. > For ARM I took the view that __u64 were the kernel's types, not > ours. The kernel header structs define fields as __u64 but for > in-QEMU functions and variables we should use the posix uint64_t. Agree. Paolo