From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOV3f-0003Tk-IS for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:34:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOV3a-0006Cg-6P for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:34:07 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:28935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOV3Z-0006Bq-US for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:34:02 -0400 Message-ID: <53232F64.7030404@huawei.com> Date: Fri, 14 Mar 2014 17:33:40 +0100 From: Claudio Fontana MIME-Version: 1.0 References: <1394352479-5625-1-git-send-email-rth@twiddle.net> In-Reply-To: <1394352479-5625-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/14] tcg/aarch64 improvements, part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, alex.bennee@linaro.org On 09.03.2014 09:07, Richard Henderson wrote: > This contains the bulk of the rearrangement into tcg_out_insn, wherein > the instructions are given format numbers and a modicum of preprocessor > based type-checking. This also contains the bulk of the unimplemented > tcg opcodes, and handling of constant arguments. > > Assuming one agrees with the general premise, these should also be > relatively trivial to review. > > > r~ It all checks good for me, with the caveat that as you know I am not fond of glue(glue(... but I see it is just how things are done all around QEMU. Tested with targets i386/dos, sparc/linux, x86-64/linux, all thumbs up. Reviewed-by: Claudio Fontana Tested-by: Claudio Fontana > > > Richard Henderson (14): > tcg-aarch64: Introduce tcg_out_insn > tcg-aarch64: Convert shift insns to tcg_out_insn > tcg-aarch64: Introduce tcg_out_insn_3401 > tcg-aarch64: Implement mov with tcg_out_insn > tcg-aarch64: Handle constant operands to add, sub, and compare > tcg-aarch64: Handle constant operands to and, or, xor > tcg-aarch64: Support andc, orc, eqv, not, neg > tcg-aarch64: Support movcond > tcg-aarch64: Use tcg_out_insn for setcond > tcg-aarch64: Support deposit > tcg-aarch64: Support add2, sub2 > tcg-aarch64: Support muluh, mulsh > tcg-aarch64: Support div, rem > tcg-aarch64: Introduce tcg_out_insn_3405 > > tcg/aarch64/tcg-target.c | 801 +++++++++++++++++++++++++++++++++-------------- > tcg/aarch64/tcg-target.h | 48 +-- > 2 files changed, 594 insertions(+), 255 deletions(-) office: +49 89 158834 4135 mobile: +49 15253060158