From: Laszlo Ersek <lersek@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Jeff Cody <jcody@redhat.com>, Alexander Graf <agraf@suse.de>,
"Richard W.M. Jones" <rjones@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants
Date: Fri, 14 Mar 2014 17:35:32 +0100 [thread overview]
Message-ID: <53232FD4.1020605@redhat.com> (raw)
In-Reply-To: <CAFEAcA-5wWCS9xGaoFafX7rS3txJQ_oqVfwZR9MUkcsUbZqwLQ@mail.gmail.com>
On 03/14/14 17:26, Peter Maydell wrote:
> On 14 March 2014 16:17, Laszlo Ersek <lersek@redhat.com> wrote:
>> "Unsigned long long" is a gnu-ism for C89. It's a standard part of C99.
>> Last time I checked, qemu used the gnu89 dialect on all build hosts
>> except SunOS.
>
> HACKING says we use C99...
HACKING lies then :)
grep for "std=c99" or "std=gnu99". You will find no hits for the former,
and one hit for the latter, when the build host is SunOS. (Or just grep
for '-std='.)
In gcc-4.8.2, -std still defaults to gnu89.
Laszlo
next prev parent reply other threads:[~2014-03-14 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 10:50 [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants Jeff Cody
2014-03-14 15:25 ` Stefan Hajnoczi
2014-03-14 15:36 ` Richard W.M. Jones
2014-03-14 15:38 ` Peter Maydell
2014-03-14 15:57 ` Richard W.M. Jones
2014-03-14 16:26 ` Laszlo Ersek
2014-03-14 16:51 ` Richard W.M. Jones
2014-03-14 17:27 ` Laszlo Ersek
2014-03-14 17:49 ` Richard W.M. Jones
2014-03-14 18:16 ` Laszlo Ersek
2014-03-14 16:17 ` Laszlo Ersek
2014-03-14 16:26 ` Peter Maydell
2014-03-14 16:35 ` Laszlo Ersek [this message]
2014-03-14 16:36 ` Laszlo Ersek
2014-03-14 17:08 ` Peter Maydell
2014-03-14 17:42 ` Laszlo Ersek
2014-03-14 18:22 ` Peter Maydell
2014-03-14 18:49 ` Laszlo Ersek
2014-03-14 18:57 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53232FD4.1020605@redhat.com \
--to=lersek@redhat.com \
--cc=agraf@suse.de \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).