From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOV5F-00055V-S9 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOV58-0006zu-Av for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:35:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOV57-0006zg-RE for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:35:38 -0400 Message-ID: <53232FD4.1020605@redhat.com> Date: Fri, 14 Mar 2014 17:35:32 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <3096076082478dafe78553ab5cbd8b572904cbc4.1394794127.git.jcody@redhat.com> <20140314153639.GD1985@redhat.com> <53232B90.5060408@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , QEMU Developers , Jeff Cody , Alexander Graf , "Richard W.M. Jones" , Stefan Hajnoczi On 03/14/14 17:26, Peter Maydell wrote: > On 14 March 2014 16:17, Laszlo Ersek wrote: >> "Unsigned long long" is a gnu-ism for C89. It's a standard part of C99. >> Last time I checked, qemu used the gnu89 dialect on all build hosts >> except SunOS. > > HACKING says we use C99... HACKING lies then :) grep for "std=c99" or "std=gnu99". You will find no hits for the former, and one hit for the latter, when the build host is SunOS. (Or just grep for '-std='.) In gcc-4.8.2, -std still defaults to gnu89. Laszlo