From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1WOVC1-0005LE-Do
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:42:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1WOVBv-0000dm-Ev
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:42:45 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:45700
	helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1WOVBv-0000dU-8U
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 12:42:39 -0400
Message-ID: <5323317D.7040109@adacore.com>
Date: Fri, 14 Mar 2014 17:42:37 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1394148857-19607-1-git-send-email-agraf@suse.de>	<1394148857-19607-74-git-send-email-agraf@suse.de>
	<5322E695.7000702@redhat.com>
In-Reply-To: <5322E695.7000702@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 073/130] Add Enhanced Three-Speed Ethernet
 Controller (eTSEC)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>

On 03/14/2014 12:23 PM, Paolo Bonzini wrote:
> Il 07/03/2014 00:33, Alexander Graf ha scritto:
>> +                if (bd.flags | BD_INTERRUPT) {
>> +                    /* Set RXFx */
>> +                    etsec->regs[RSTAT].value |= 1 << (7 - ring_nbr);
>> +
>> +                    /* Set IEVENT */
>> +                    ievent_set(etsec, IEVENT_RXF);
>> +                }
>> +
>> +            } else {
>> +                if (bd.flags | BD_INTERRUPT) {
>> +                    /* Set IEVENT */
>> +                    ievent_set(etsec, IEVENT_RXB);
>> +                }
>> +            }
> 
> Coverity flags this "bd.flags | BD_INTERRUPT" idiom... What did you mean?  Can you send a fix to qemu-trivial?
> 

That's a very bad mistake indeed, it's supposed to be a "bd.flags & BD_INTERRUPT"...