From: Laszlo Ersek <lersek@redhat.com>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0] scripts/make-release: Don't distribute .git directories
Date: Fri, 14 Mar 2014 19:30:17 +0100 [thread overview]
Message-ID: <53234AB9.8050008@redhat.com> (raw)
In-Reply-To: <7bd1da678bd39335a69894433070611baf7c2968.1394815484.git.crobinso@redhat.com>
On 03/14/14 17:45, Cole Robinson wrote:
> [crobinso@localhost qemu-2.0.0-rc0]$ find . -name .git
> ./dtc/.git
> ./pixman/.git
>
> This is already done for the rom submodules.
>
> https://bugs.launchpad.net/qemu/+bug/1224414
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> scripts/make-release | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 196c755..cb7c2da 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -18,7 +18,7 @@ git clone "${src}" ${destination}
> pushd ${destination}
> git checkout "v${version}"
> git submodule update --init
> -rm -rf .git roms/*/.git
> +rm -rf .git roms/*/.git dtc/.git pixman/*.git
> popd
> tar cfj ${destination}.tar.bz2 ${destination}
> rm -rf ${destination}
>
This seems to be complete:
.gitmodules:[submodule "roms/vgabios"]
.gitmodules:[submodule "roms/seabios"]
.gitmodules:[submodule "roms/SLOF"]
.gitmodules:[submodule "roms/ipxe"]
.gitmodules:[submodule "roms/openbios"]
.gitmodules:[submodule "roms/openhackware"]
.gitmodules:[submodule "roms/qemu-palcode"]
.gitmodules:[submodule "roms/sgabios"]
.gitmodules:[submodule "pixman"]
.gitmodules:[submodule "dtc"]
but did you in fact mean
pixman/*.git
rather tan
pixman/.git
?
Thanks
Laszlo
next prev parent reply other threads:[~2014-03-14 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 16:45 [Qemu-devel] [PATCH for-2.0] scripts/make-release: Don't distribute .git directories Cole Robinson
2014-03-14 18:30 ` Laszlo Ersek [this message]
2014-03-14 19:38 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53234AB9.8050008@redhat.com \
--to=lersek@redhat.com \
--cc=aliguori@amazon.com \
--cc=crobinso@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).