From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXUC-0003yT-Qa
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:09:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXU6-0005Xm-RR
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:09:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXU6-0005Xh-Ja
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:09:34 -0400
Message-ID: <532353EB.7030804@redhat.com>
Date: Fri, 14 Mar 2014 20:09:31 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1394823137-4369-1-git-send-email-ehabkost@redhat.com>
	<1394823137-4369-7-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1394823137-4369-7-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 6/7] vl.c: Rename MAX_CPUMASK_BITS to
	MAX_CPUS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

one important nit :)

On 03/14/14 19:52, Eduardo Habkost wrote:
> Also, document what the macro is really useful for.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  include/sysemu/sysemu.h |  9 ++++++++-
>  vl.c                    | 10 +++++-----
>  2 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index b90df9a..a73b226 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -133,7 +133,14 @@ extern uint8_t qemu_extra_params_fw[2];
>  extern QEMUClockType rtc_clock;
>  
>  #define MAX_NODES 64
> -#define MAX_CPUMASK_BITS 255
> +
> +/* The following should be true for all CPUs:

Not should, "shall". It's an invariant we enforce, not something we
merely suggest.

You can add my R-b to the v4 posting.

Thanks,
Laszlo