From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXWT-0005jg-DV
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:12:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXWN-0006GK-BK
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:12:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20092)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WOXWN-0006FP-2p
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 15:11:55 -0400
Message-ID: <53235476.4040305@redhat.com>
Date: Fri, 14 Mar 2014 20:11:50 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1394823137-4369-1-git-send-email-ehabkost@redhat.com>
	<1394823137-4369-8-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1394823137-4369-8-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 7/7] vl.c: Use MAX_CPUS macro instead of
 hardcoded constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

On 03/14/14 19:52, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 64b38a5..62cc734 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1413,7 +1413,7 @@ static void smp_parse(QemuOpts *opts)
>          max_cpus = smp_cpus;
>      }
>  
> -    if (max_cpus > 255) {
> +    if (max_cpus > MAX_CPUS) {
>          fprintf(stderr, "Unsupported number of maxcpus\n");
>          exit(1);
>      }
> 

$ git grep -e '255' --and -e cpus

hw/s390x/s390-virtio-ccw.c:    .max_cpus = 255,
hw/s390x/s390-virtio.c:    .max_cpus = 255,
include/hw/i386/pc.h:    .max_cpus = 255
vl.c:    if (max_cpus > 255) {

I propose to fix those other tree occurrences as well. (I could be
easily wrong of course!, I didn't investigate.)

Thanks
Laszlo