From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WP5zp-00074Z-0d
	for qemu-devel@nongnu.org; Sun, 16 Mar 2014 04:00:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WP5zg-0004lT-E2
	for qemu-devel@nongnu.org; Sun, 16 Mar 2014 04:00:36 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <532559FE.4060808@redhat.com>
Date: Sun, 16 Mar 2014 08:59:58 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394908420-6981-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-iLNU5g236yhp7ie6-dqpxNpG=EMz8tXhOXs9aPnaS+Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-iLNU5g236yhp7ie6-dqpxNpG=EMz8tXhOXs9aPnaS+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-alpha: fix subl and s8subl
	indentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

Il 16/03/2014 00:47, Peter Maydell ha scritto:
> On 15 March 2014 18:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Two missing braces, one close and one open, fabulously let the code
>> compile.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  target-alpha/translate.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
>> index a9ef1a7..e7e319b 100644
>> --- a/target-alpha/translate.c
>> +++ b/target-alpha/translate.c
>> @@ -1927,6 +1927,7 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn)
>>                      else {
>>                          tcg_gen_neg_i64(cpu_ir[rc], cpu_ir[rb]);
>>                          tcg_gen_ext32s_i64(cpu_ir[rc], cpu_ir[rc]);
>> +                    }
>>                  }
>>              }
>>              break;
>> @@ -1991,7 +1992,7 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn)
>>                  } else {
>>                      if (islit)
>>                          tcg_gen_movi_i64(cpu_ir[rc], -lit);
>> -                    else
>> +                    else {
>>                          tcg_gen_neg_i64(cpu_ir[rc], cpu_ir[rb]);
>>                          tcg_gen_ext32s_i64(cpu_ir[rc], cpu_ir[rc]);
>>                      }
>
> I'm surprised checkpatch didn't insist you added braces to the "if"
> half of this if-else as well.

I must admit I ignored it.  It makes the patch harder to review, since 
the bug is explicitly about missing (unmatched) braces.  I can add the 
braces throughout the file, but I don't think it's a reason to obfuscate 
this particular patch.

Paolo