From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPU8n-0007js-Nb
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 05:47:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPU8h-0001xA-O2
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 05:47:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPU8h-0001wv-Fk
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 05:47:23 -0400
Message-ID: <5326C498.5040705@redhat.com>
Date: Mon, 17 Mar 2014 10:47:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5322F415.4070409@redhat.com>
	<20140317093114.GA5392@noname.str.redhat.com>
In-Reply-To: <20140317093114.GA5392@noname.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Coverity scan successes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: mattjd@gmail.com, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel <qemu-devel@nongnu.org>

Il 17/03/2014 10:31, Kevin Wolf ha scritto:
>
> Am 14.03.2014 um 13:20 hat Paolo Bonzini geschrieben:
>> > Of course, the defect density varies across subsystems:
>> >
>> > 					ratio		# defects
>> > 	SLIRP				2.86		20
>> > 	9pfs/virtio-9p			1.69		16
>> > 	Bluetooth			1.31		6
>> > 	NBD				1.31		2
>> > 	User-mode emulation		0.84		25
>> > 	Block layer			0.66		25
> How would I get access to the Coverity results?

You ask. :)

> I feel the block layer
> is scoring a bit too high here... :-)

Well, five of those are simply new unchecked uses of strstart that 
Coverity complains about and I've muted them so you're already down to 
0.5. :)

Most of the problems are overflows caused by int32 multiplications (such 
as number of sectors * 512, or number of clusters * clusters per sector) 
before casting to int64.  Many of them probably cannot really happen, 
because one of the factor is small and related to the size of an L2 
table; for example the number of sectors could be the size of an L2 
table, or the number of clusters could be the number of entries in an L2 
table.

Paolo