From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPUPl-0000j2-0z
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:05:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPUPe-0007OB-Sv
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:05:00 -0400
Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:59162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPUPe-0007O5-LE
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:04:54 -0400
Received: by mail-ee0-f51.google.com with SMTP id c13so3881987eek.24
	for <qemu-devel@nongnu.org>; Mon, 17 Mar 2014 03:04:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5326C8C1.3020108@redhat.com>
Date: Mon, 17 Mar 2014 11:04:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394763665-30619-1-git-send-email-famz@redhat.com>
In-Reply-To: <1394763665-30619-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.0] rules.mak: Fix per object libs
	extraction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Christian Mahnke <cmahnke@googlemail.com>

Il 14/03/2014 03:21, Fam Zheng ha scritto:
> Don't sort the extracted options, sort the objects.
>
> Reported-by: Christian Mahnke <cmahnke@googlemail.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  rules.mak | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 9dda9f7..5c454d8 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -23,8 +23,8 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>  QEMU_INCLUDES += -I$(<D) -I$(@D)
>
>  maybe-add = $(filter-out $1, $2) $1
> -extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs)) \
> -                  $(foreach o,$(call expand-objs,$1),$($o-libs))))
> +extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs))) \
> +                  $(foreach o,$(call expand-objs,$1),$($o-libs)))
>  expand-objs = $(strip $(sort $(filter %.o,$1)) \
>                    $(foreach o,$(filter %.mo,$1),$($o-objs)) \
>                    $(filter-out %.o %.mo,$1))
>

Thanks, I'll send a pull request with this and the other patch.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>