qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling
Date: Mon, 17 Mar 2014 11:50:39 +0100	[thread overview]
Message-ID: <5326D37F.6030704@redhat.com> (raw)
In-Reply-To: <8761ndgrnf.fsf@blackfin.pond.sub.org>

Il 17/03/2014 09:23, Markus Armbruster ha scritto:
> > This patch makes all names in option table to match with actual
> > command-line spelling, it will be helpful when we search in option
> > tables.
>
> As discussed in [*], the QemuOptsList member name values are ABI:
> changing them can break existing -readconfig configuration files.  If we
> decide breaking ABI is okay here (big if!), we need to document it
> prominently in the commit message.

I think in some (rare) cases breaking the rule is okay.  For example, 
the pending conversion of "-m" to QemuOpts uses "memory".

However, I don't think adding "-opts" is a good thing to do.  Which one 
is most readable?

    [m]
       size = 128M
       max = 512M

    [memory]
       size = 128M
       max = 512M

    [memory-opts]
       size = 128M
       max = 512M

I'm for including this patch in 2.0.

Paolo

  reply	other threads:[~2014-03-17 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17  5:24 [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling Amos Kong
2014-03-17  8:23 ` Markus Armbruster
2014-03-17 10:50   ` Paolo Bonzini [this message]
2014-03-17 12:33     ` Markus Armbruster
2014-03-17 13:36       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5326D37F.6030704@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=akong@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).