From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55155)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPV89-0007Ia-17
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:51:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPV80-0004hn-Ls
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:50:52 -0400
Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:35218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPV80-0004hc-94
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 06:50:44 -0400
Received: by mail-ee0-f41.google.com with SMTP id t10so4022110eei.28
	for <qemu-devel@nongnu.org>; Mon, 17 Mar 2014 03:50:43 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5326D37F.6030704@redhat.com>
Date: Mon, 17 Mar 2014 11:50:39 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1395033894-21613-1-git-send-email-akong@redhat.com>
	<8761ndgrnf.fsf@blackfin.pond.sub.org>
In-Reply-To: <8761ndgrnf.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] update names in option tables to match
 with actual command-line spelling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de

Il 17/03/2014 09:23, Markus Armbruster ha scritto:
> > This patch makes all names in option table to match with actual
> > command-line spelling, it will be helpful when we search in option
> > tables.
>
> As discussed in [*], the QemuOptsList member name values are ABI:
> changing them can break existing -readconfig configuration files.  If we
> decide breaking ABI is okay here (big if!), we need to document it
> prominently in the commit message.

I think in some (rare) cases breaking the rule is okay.  For example, 
the pending conversion of "-m" to QemuOpts uses "memory".

However, I don't think adding "-opts" is a good thing to do.  Which one 
is most readable?

    [m]
       size = 128M
       max = 512M

    [memory]
       size = 128M
       max = 512M

    [memory-opts]
       size = 128M
       max = 512M

I'm for including this patch in 2.0.

Paolo