From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPaAL-0001P8-5C for qemu-devel@nongnu.org; Mon, 17 Mar 2014 12:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPaAA-0003y0-0q for qemu-devel@nongnu.org; Mon, 17 Mar 2014 12:13:29 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:42995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPaA9-0003xX-Nt for qemu-devel@nongnu.org; Mon, 17 Mar 2014 12:13:17 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Mar 2014 16:13:16 -0000 Message-ID: <53271F18.7080201@de.ibm.com> Date: Mon, 17 Mar 2014 17:13:12 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1394722501-32326-1-git-send-email-afaerber@suse.de> <1394722501-32326-57-git-send-email-afaerber@suse.de> In-Reply-To: <1394722501-32326-57-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH]: exec: fix cpu rework fallout (was cputlb: Change tlb_flush() argument to CPUState) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Peter Maydell , Jia Liu , Anthony Green , Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , PowerPC , "Edgar E. Iglesias" , Guan Xuetao , Aurelien Jarno , Richard Henderson I need the following to not crash on migration post load: tlb_flush wants an CPUState. This was unnoticed by gcc because env_ptr is a void pointer. Signed-off-by: Christian Borntraeger --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/exec.c +++ b/exec.c @@ -420,7 +420,7 @@ static int cpu_common_post_load(void *opaque, int version_id) /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the version_id is increased. */ cpu->interrupt_request &= ~0x01; - tlb_flush(cpu->env_ptr, 1); + tlb_flush(cpu, 1); return 0; }