From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPdyK-0006cD-Ja for qemu-devel@nongnu.org; Mon, 17 Mar 2014 16:17:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPdyD-0006AE-Fr for qemu-devel@nongnu.org; Mon, 17 Mar 2014 16:17:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39439 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPdyD-0006AA-93 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 16:17:13 -0400 Message-ID: <53275848.9040004@suse.de> Date: Mon, 17 Mar 2014 21:17:12 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1395057331-12329-1-git-send-email-riku.voipio@linaro.org> In-Reply-To: <1395057331-12329-1-git-send-email-riku.voipio@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: don't warn on missing capget/capset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: riku.voipio@linaro.org, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Alexander Graf Am 17.03.2014 12:55, schrieb riku.voipio@linaro.org: > From: Riku Voipio >=20 > some people get numerous unimplemented capget/capset warnings. Since qe= mu > linux-user is not secure to begin with, just skip the system call > warning for now. Proper capset/capget to be added in Qemu 2.1 "QEMU". Drop "qemu" above? >=20 > Signed-off-by: Riku Voipio Since Peter specifically mentioned to you that this is what the SUSE tree does, it would be only fair to attribute this change to Alex as patch author in some way, be it Signed-off-by, From or Suggested-by: https://github.com/openSUSE/qemu/commit/b0817614daa8594bcc10dff88b384027d= 00deb1f Note that we only seemed to skip the warning for capget. Regards, Andreas > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index e404a32..4bfa3db 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -7677,9 +7677,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_l= ong arg1, > unlock_user(p, arg1, ret); > break; > case TARGET_NR_capget: > - goto unimplemented; > + goto unimplemented_nowarn; > case TARGET_NR_capset: > - goto unimplemented; > + goto unimplemented_nowarn; > case TARGET_NR_sigaltstack: > #if defined(TARGET_I386) || defined(TARGET_ARM) || defined(TARGET_MIPS= ) || \ > defined(TARGET_SPARC) || defined(TARGET_PPC) || defined(TARGET_ALP= HA) || \ >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg