From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39163)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPoRk-0000ii-8l
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 03:28:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPoRb-0004j5-OD
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 03:28:24 -0400
Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:60342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WPoRb-0004is-Bc
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 03:28:15 -0400
Received: by mail-ee0-f44.google.com with SMTP id e49so4963102eek.17
	for <qemu-devel@nongnu.org>; Tue, 18 Mar 2014 00:28:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5327F58A.4080007@redhat.com>
Date: Tue, 18 Mar 2014 08:28:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1392073373-3295-1-git-send-email-robherring2@gmail.com>
	<CAFEAcA8BXPvYAO_k866-y2BD8o1HB=2sbZnoCSsVULo3azpn1w@mail.gmail.com>
In-Reply-To: <CAFEAcA8BXPvYAO_k866-y2BD8o1HB=2sbZnoCSsVULo3azpn1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ahci: fix sysbus support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Rob Herring <robherring2@gmail.com>
Cc: Rob Herring <rob.herring@linaro.org>, Jason Baron <jbaron@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 11/02/2014 01:32, Peter Maydell ha scritto:
>> > @@ -1311,7 +1312,7 @@ static const VMStateDescription vmstate_sysbus_ahci = {
>> >      .name = "sysbus-ahci",
>> >      .unmigratable = 1, /* Still buggy under I/O load */
>> >      .fields = (VMStateField []) {
>> > -        VMSTATE_AHCI(ahci, AHCIPCIState),
>> > +        VMSTATE_AHCI(ahci, SysbusAHCIState),
>> >          VMSTATE_END_OF_LIST()
>> >      },
> ...I wonder if that fixes the "buggy under I/O load" issue the
> comment is talking about. Jason, do you still have whatever
> testcase you were using when you added that comment?

No, because PCI AHCI is also buggy under I/O load.

Paolo