From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-alpha: fix the braces
Date: Tue, 18 Mar 2014 12:14:39 +0100 [thread overview]
Message-ID: <53282A9F.8010904@redhat.com> (raw)
In-Reply-To: <532739C6.1050608@twiddle.net>
Il 17/03/2014 19:07, Richard Henderson ha scritto:
> On 03/17/2014 04:28 AM, Paolo Bonzini wrote:
>> Conform to coding style, and avoid further occurrences of bugs due to
>> misplaced braces.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> target-alpha/translate.c | 313 +++++++++++++++++++++++++++--------------------
>> 1 file changed, 180 insertions(+), 133 deletions(-)
>
> I was considering going through the alpha translator and dropping all the
> highly unlikely tests and stuff that can now be handled by the tcg optimizers.
> In the process I'd touch most of these lines and fix the conformance.
>
> But if we'd prefer to fix them all at once, that's fine too.
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
As you prefer---I submitted this patch just to follow up on my promise
to check the braces separately from the other day's fix.
Paolo
next prev parent reply other threads:[~2014-03-18 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:28 [Qemu-devel] [PATCH] target-alpha: fix the braces Paolo Bonzini
2014-03-17 18:07 ` Richard Henderson
2014-03-18 11:14 ` Paolo Bonzini [this message]
2014-03-18 21:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53282A9F.8010904@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).