From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPwXV-0008Iq-Jf for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:07:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPwXM-0004Ed-L8 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:06:53 -0400 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:62743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPwXM-0004EV-Gi for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:06:44 -0400 Received: by mail-qc0-f180.google.com with SMTP id w7so1610659qcr.11 for ; Tue, 18 Mar 2014 09:06:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <53286F0F.6020909@twiddle.net> Date: Tue, 18 Mar 2014 09:06:39 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1395157702-23108-1-git-send-email-rth@twiddle.net> <1395157702-23108-2-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] tcg: Mask shift quantities while folding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 03/18/2014 08:59 AM, Peter Maydell wrote: > Don't you also need to do something similar for the > "calculate known-zeroes bits" code on lines 807..833 ? Yep. r~