From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
qemu-devel@nongnu.org
Cc: gleb@kernel.org, borntraeger@de.ibm.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2 5/5] KVM: Bump KVM_MAX_IRQ_ROUTES for s390
Date: Tue, 18 Mar 2014 17:07:35 +0100 [thread overview]
Message-ID: <53286F47.2020100@redhat.com> (raw)
In-Reply-To: <1395079899-29239-6-git-send-email-cornelia.huck@de.ibm.com>
Il 17/03/2014 19:11, Cornelia Huck ha scritto:
> The maximum number for irq routes is currently 1024, which is a bit on
> the small size for s390: We support up to 4 x 64k virtual devices with
> up to 64 queues, and we need one route for each of the queues if we want
> to operate it via irqfd.
>
> Let's bump this to 4k on s390 for now, as this at least covers the saner
> setups.
>
> We need to find a more general solution, though, as we can't just grow
> the routing table indefinitly.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> include/linux/kvm_host.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index da7510b..7d21cf9 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -922,7 +922,11 @@ static inline int mmu_notifier_retry(struct kvm *kvm, unsigned long mmu_seq)
>
> #ifdef CONFIG_HAVE_KVM_IRQ_ROUTING
>
> +#ifdef CONFIG_S390
> +#define KVM_MAX_IRQ_ROUTES 4096 //FIXME: we can have more than that...
> +#else
> #define KVM_MAX_IRQ_ROUTES 1024
> +#endif
>
> int kvm_setup_default_irq_routing(struct kvm *kvm);
> int kvm_set_irq_routing(struct kvm *kvm,
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2014-03-18 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 18:11 [Qemu-devel] [PATCH v2 0/5] KVM: irqfds for s390 Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion Cornelia Huck
2014-03-17 21:55 ` Christian Borntraeger
2014-03-18 9:18 ` Cornelia Huck
2014-03-18 16:05 ` Paolo Bonzini
2014-03-17 18:11 ` [Qemu-devel] [PATCH v2 2/5] KVM: Add per-vm capability enablement Cornelia Huck
2014-03-17 22:09 ` Christian Borntraeger
2014-03-21 9:12 ` Christian Borntraeger
2014-03-17 18:11 ` [Qemu-devel] [PATCH v2 3/5] KVM: s390: adapter interrupt sources Cornelia Huck
2014-03-18 8:11 ` Heiko Carstens
2014-03-18 8:41 ` Cornelia Huck
2014-03-21 9:26 ` Christian Borntraeger
2014-03-21 10:07 ` Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] [PATCH v2 4/5] KVM: s390: irq routing for adapter interrupts Cornelia Huck
2014-03-21 9:32 ` Christian Borntraeger
2014-03-21 10:08 ` Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] [PATCH v2 5/5] KVM: Bump KVM_MAX_IRQ_ROUTES for s390 Cornelia Huck
2014-03-18 16:07 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53286F47.2020100@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).