From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPwdm-00065D-BR
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:13:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPwdf-0006WK-Ae
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:13:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WPwdf-0006W9-14
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:13:15 -0400
Message-ID: <53287090.10105@redhat.com>
Date: Tue, 18 Mar 2014 17:13:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1395079921-29325-1-git-send-email-cornelia.huck@de.ibm.com>
	<1395079921-29325-6-git-send-email-cornelia.huck@de.ibm.com>
In-Reply-To: <1395079921-29325-6-git-send-email-cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 5/5] s390x/virtio-ccw: Wire up irq
	routing and irqfds.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org
Cc: gleb@kernel.org, borntraeger@de.ibm.com, agraf@suse.de

Il 17/03/2014 19:12, Cornelia Huck ha scritto:
>      if (!qemu_opt_get_bool(qemu_get_machine_opts(), "kernel_irqchip", true) ||
> -        !kvm_check_extension(s, KVM_CAP_IRQCHIP)) {
> +        (!kvm_check_extension(s, KVM_CAP_IRQCHIP) &&
> +         kvm_enable_cap_vm(s, KVM_CAP_S390_IRQCHIP))) {

Please add a "< 0" here for clarity.

Paolo