From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPyQQ-0000Sb-5c for qemu-devel@nongnu.org; Tue, 18 Mar 2014 14:07:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPyQJ-00038j-SL for qemu-devel@nongnu.org; Tue, 18 Mar 2014 14:07:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPyQJ-000381-Jo for qemu-devel@nongnu.org; Tue, 18 Mar 2014 14:07:35 -0400 Message-ID: <53288B62.3060200@redhat.com> Date: Tue, 18 Mar 2014 19:07:30 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1395154048-28278-1-git-send-email-mst@redhat.com> <1395154048-28278-2-git-send-email-mst@redhat.com> In-Reply-To: <1395154048-28278-2-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Anthony Liguori , Marcel Apfelbaum On 03/18/14 15:48, Michael S. Tsirkin wrote: > when using signature for table ID, we forgot to byte-swap it. > signatures are really ASCII strings, let's treat them as such. > While at it, get rid of most of _SIGNATURE macros. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acpi-defs.h | 14 -------------- > hw/i386/acpi-build.c | 31 ++++++++++++++++--------------- > 2 files changed, 16 insertions(+), 29 deletions(-) Looks reasonable. Of course you'll probably want Marcel's R-b. Reviewed-by: Laszlo Ersek