From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQ1IY-00078V-JS for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQ1IS-0001iI-O1 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:11:46 -0400 Received: from mail-qa0-x22c.google.com ([2607:f8b0:400d:c00::22c]:44313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQ1IS-0001iE-JK for qemu-devel@nongnu.org; Tue, 18 Mar 2014 17:11:40 -0400 Received: by mail-qa0-f44.google.com with SMTP id f11so7681981qae.31 for ; Tue, 18 Mar 2014 14:11:40 -0700 (PDT) Sender: Richard Henderson Message-ID: <5328B688.5010808@twiddle.net> Date: Tue, 18 Mar 2014 14:11:36 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1395055682-24686-1-git-send-email-pbonzini@redhat.com> <532739C6.1050608@twiddle.net> <53282A9F.8010904@redhat.com> In-Reply-To: <53282A9F.8010904@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-alpha: fix the braces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 03/18/2014 04:14 AM, Paolo Bonzini wrote: > Il 17/03/2014 19:07, Richard Henderson ha scritto: >> On 03/17/2014 04:28 AM, Paolo Bonzini wrote: >>> Conform to coding style, and avoid further occurrences of bugs due to >>> misplaced braces. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> target-alpha/translate.c | 313 +++++++++++++++++++++++++++-------------------- >>> 1 file changed, 180 insertions(+), 133 deletions(-) >> >> I was considering going through the alpha translator and dropping all the >> highly unlikely tests and stuff that can now be handled by the tcg optimizers. >> In the process I'd touch most of these lines and fix the conformance. >> >> But if we'd prefer to fix them all at once, that's fine too. >> >> Reviewed-by: Richard Henderson > > As you prefer---I submitted this patch just to follow up on my promise to check > the braces separately from the other day's fix. Please go ahead with what you've got. Via trivial? r~