From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55712)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQ6Uj-0000Tw-7P
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 22:44:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQ6Ua-0000kn-MZ
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 22:44:41 -0400
Received: from mail-pb0-x22a.google.com ([2607:f8b0:400e:c01::22a]:47806)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WQ6Ua-0000jl-Et
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 22:44:32 -0400
Received: by mail-pb0-f42.google.com with SMTP id rr13so8257736pbb.29
	for <qemu-devel@nongnu.org>; Tue, 18 Mar 2014 19:44:31 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5329048B.5000909@twiddle.net>
Date: Tue, 18 Mar 2014 19:44:27 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <20140318234357.21950@gmx.com>
In-Reply-To: <20140318234357.21950@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Re : Re: [PATCH] sparc32 : Signed integer division
 overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olivier DANET <odanet@caramail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>

On 03/18/2014 04:43 PM, Olivier DANET wrote:
>>> - x0 = x0 < 0 ? 0x80000000 : 0x7fffffff;
>>> > > + } else if (x1 == -1 && x0 == 0x8000000000000000) {
>>> > > + x0 = 0x7fffffff;
>>> > > overflow = 1;
>> > 
>> > Thanks for the patch! I think based upon Peter's recent series that the 
>> > sign constant would need a ULL suffix in order to function correctly on 
>> > 32-bit platforms.
>> > 
>> > My personal preference would be for (1ULL << 63) unless Peter (CC added) 
>> > can think of a reason to leave the hex constant in its current form?
>> > 
>> > That said, I've tested the patch on a Debian etch Linux image and it 
>> > works for me.
>> > 
> The constant lacks an "ULL" indeed, sorry.
> 
> There are both (1ULL << 63) and 0x8000000000000000[ULL] constants in QEMU code, 
> and not a single 9223372036854775808ULL...
> 
> At least, with (1ULL << 63), we are not tempted to count the zeros.

Not to bike-shed this too much, but INT32_MIN and INT64_MIN would be better and
more descriptive for these.  Honestly, we're supposed to be dealing with signed
numbers here, not the unsigned number you're creating above.


r~