From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFBX-0001bl-FM for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQFBR-0003xX-NF for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:01:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFBR-0003xS-G5 for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:01:21 -0400 Message-ID: <532986C3.6000607@redhat.com> Date: Wed, 19 Mar 2014 06:00:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140312153631.GE29225@otherpad.lan.raisama.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4qf6JtUaaIBOOBnmmJLQFV6iaif8sdjFT" Subject: Re: [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , Eduardo Habkost , qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4qf6JtUaaIBOOBnmmJLQFV6iaif8sdjFT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/19/2014 02:53 AM, Chen Fan wrote: > at present, after hotplug a discontinuous cpu id on source, then done m= igration, > on target, it will fail to add the unoccupied cpu id which was skipped = at source, > this cause is on target Qemu prebuild CPU with continuous cpu_index. so= after > migration, the cpu infrastructure bewteen source and target are differe= nt. > =20 > I suppose we could use apic_id as instance_id which was used at registe= ring vmstate > when create cpu. on target, we prebuild the specified cpu topology usin= g comand line: > -device /machine/node[]/socket[]/core[]/cpu[], then migration, we cou= ld keep the same > cpu infrastructure on both side. >=20 > RFC: > V4: rename CpuTopoInfo to X86CPUTopoInfo. and move cpu_exsit() to pc_n= ew_cpu(). >=20 > V3: get rid of thread object and tie link to directly. and= prebuild full > core[] and thread[] as init socket[] according to smp_cores and smp_t= hreads. >=20 > TODO: > 1. add cpu "path" property which used for specifying the QOM path. > 2. add -device cpu-foo.path supported. > 3. then we could introduce hot-remove cpu probably. >=20 > I don't know wether this way is right or not. pls tell me. :) When sending a cover letter for a new revision of a patch series, we generally do NOT use In-Reply-To headers, but instead send it as a new thread. Patches are harder to see when they are buried as a reply to another thread. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4qf6JtUaaIBOOBnmmJLQFV6iaif8sdjFT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTKYbDAAoJEKeha0olJ0Nq4VUH/2EJhuP4gTXriMhqBWJlPHGN 7tuohl9NCcpuhTg5X3XtmefzLFBVYeVXvkThtvOIwb+wE7zdYt1sjFzA3agQFgqu JW5jGD7GzZzV/eQhorVDPBYrA9IfmwTMy4mDViU7YA4FC9bEz9htzNEOHUB4oe2r pCp4jGPfm9eXrnFTkubgWk/teyzd1foX8PcIDYn5S7qXp8h8TJwdv6pDaE5mwYF0 Ca1MXVgQ4pay7TPLi0hUY+eZI4V1eZwN1h8IS7alkxHpl2Cb+AzMyIH2W93xrll3 oNQh38VXex3hHR6SMXby944O3+3373Ni1CfFAMvxfWcmDvGiHbjxa54zd4QxFig= =t2nf -----END PGP SIGNATURE----- --4qf6JtUaaIBOOBnmmJLQFV6iaif8sdjFT--