From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQFka-0005Cn-QS
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:37:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQFkS-0000AM-9W
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:37:40 -0400
Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:58080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQFkS-0000AH-2D
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:37:32 -0400
Received: by mail-ee0-f54.google.com with SMTP id d49so6651598eek.27
	for <qemu-devel@nongnu.org>; Wed, 19 Mar 2014 05:37:31 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53298F7F.7050000@redhat.com>
Date: Wed, 19 Mar 2014 13:37:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394719868-24312-1-git-send-email-stefanha@redhat.com>	<1394719868-24312-14-git-send-email-stefanha@redhat.com>	<53271A5B.9080906@de.ibm.com>
	<53297939.1080306@de.ibm.com>
In-Reply-To: <53297939.1080306@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace
 internal thread with IOThread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Dominik Dingel <dingel@linux.vnet.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Anthony Liguori <aliguori@amazon.com>, Cornelia Huck <cornelia.huck@de.ibm.com>

Il 19/03/2014 12:02, Christian Borntraeger ha scritto:
>         Error *local_err = NULL;
>
>         s->internal_iothread = true;
>         object_add(TYPE_IOTHREAD, vdev->name, NULL, NULL, &local_err);

This should instead use object_new and object_property_add_child to add 
an "internal-iothread" child to the virtio-blk device.

The namespace of -object/object-add/object_add is private to the user, 
QEMU code should not touch it.

Paolo

>         if (error_is_set(&local_err)) {
>             error_propagate(errp, local_err);
>             g_free(s);
>             return;
>         }
>         s->iothread = iothread_find(vdev->name);
>         assert(s->iothread);
>     }
>     s->ctx = iothread_get_aio_context(s->iothread);