From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFnA-0007UN-EL for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQFn1-0001Cs-Ar for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:40:20 -0400 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:56027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFn1-0001Ch-3u for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:40:11 -0400 Received: by mail-ee0-f44.google.com with SMTP id e49so6549516eek.17 for ; Wed, 19 Mar 2014 05:40:10 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53299026.1080905@redhat.com> Date: Wed, 19 Mar 2014 13:40:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395227624-20725-1-git-send-email-dgilbert@redhat.com> <20140319113429.GG2371@work-vm> In-Reply-To: <20140319113429.GG2371@work-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] Coverity: Fix failure path for qemu_accept in migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Peter Maydell Cc: QEMU Developers , Juan Quintela Il 19/03/2014 12:34, Dr. David Alan Gilbert ha scritto: >>> > > + fprintf(stderr, "could not accept migration connection (%d)\n", err); >> > >> > Bit unfriendly not to convert the errno to a string. > I could reroll it with a strerror. Since you are at it, please use error_report too. Paolo