From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFwt-0008K8-1e for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:50:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQFwk-0004jk-Nl for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:50:22 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:58188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQFwk-0004jL-HE for qemu-devel@nongnu.org; Wed, 19 Mar 2014 08:50:14 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Mar 2014 06:50:13 -0600 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 441BFC90043 for ; Wed, 19 Mar 2014 08:50:07 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2JCoAXp3801428 for ; Wed, 19 Mar 2014 12:50:10 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2JCoApf022012 for ; Wed, 19 Mar 2014 08:50:10 -0400 Message-ID: <53299281.9070304@linux.vnet.ibm.com> Date: Wed, 19 Mar 2014 08:50:09 -0400 From: Matthew Rosato MIME-Version: 1.0 References: <1393277453-13942-1-git-send-email-mjrosato@linux.vnet.ibm.com> <531DCEAF.7090506@linux.vnet.ibm.com> In-Reply-To: <531DCEAF.7090506@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, gleb@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, imammedo@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net On 03/10/2014 10:39 AM, Matthew Rosato wrote: > On 02/24/2014 04:30 PM, Matthew Rosato wrote: >> This patchset adds support in s390 for a pool of standby memory, >> which can be set online/offline by the guest (ie, via chmem). >> New options, maxmem and slots, are added to the QEMU command line >> memory parameter to specify the total amount of memory available >> to the guest as well as the number of memory slots available. >> As part of this work, additional results are provided for the >> Read SCP Information SCLP, and new implentation is added for the >> Read Storage Element Information, Attach Storage Element, >> Assign Storage and Unassign Storage SCLPs, which enables the s390 >> guest to manipulate the standby memory pool. >> >> This patchset is based on work originally done by Jeng-Fang (Nick) >> Wang. >> >> This patchset has been built to apply on the s390-next tree at: >> >> git://github.com/borntraeger/qemu.git s390-next >> >> Changes for v2: >> * Removed the patch that introduced the standby-mem operand and >> instead included Igor Mammedov's patches that add the mem-opts >> 'maxmem' and 'slots', with a slight modification due to the removal >> of qemu_opts_create_nofail. >> * Patch 3 was inserted to add a new qom object that encapsulate variables >> used by s390 memory hotplug. Patches 4 and 5 adjusted to use this >> object. >> * Added additional code comments and other minor changes per Alexander >> Graf's comments >> >> Igor Mammedov (2): >> vl: convert -m to QemuOpts >> vl.c: extend -m option to support options for memory hotplug >> >> Matthew Rosato (3): >> sclp-s390: Add device to manage s390 memory hotplug >> virtio-ccw: Include standby memory when calculating storage increment >> sclp-s390: Add memory hotplug SCLPs >> >> hw/s390x/s390-virtio-ccw.c | 42 +++++-- >> hw/s390x/sclp.c | 276 ++++++++++++++++++++++++++++++++++++++++++-- >> include/hw/s390x/sclp.h | 19 +++ >> qemu-options.hx | 10 +- >> target-s390x/cpu.h | 18 +++ >> target-s390x/kvm.c | 5 + >> vl.c | 98 ++++++++++++++-- >> 7 files changed, 440 insertions(+), 28 deletions(-) >> > > Ping. Patches 3-5 in particular could still use a review. > Ping.