From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WQICX-0006J9-EX
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 11:14:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WQICR-00042B-A9
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 11:14:41 -0400
Message-ID: <5329B438.7090104@gmail.com>
Date: Wed, 19 Mar 2014 10:14:00 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <20140319140726.GA9192@zubnet.me.uk>
In-Reply-To: <20140319140726.GA9192@zubnet.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Fix overallocation
	of opcode tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdb@zubnet.me.uk>, qemu-trivial@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 3/19/2014 9:07 AM, Stuart Brady wrote:
> create_new_table() should allocate 0x20 opc_handler_t pointers, but
> actually allocates 0x20 opc_handler_t structs.  Fix this.
> 
> Signed-off-by: Stuart Brady <sdb@zubnet.me.uk>
> ---
>  translate_init.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 6084f40..75f34c1 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7434,7 +7434,7 @@ static int create_new_table (opc_handler_t **table, unsigned char idx)
>  {
>      opc_handler_t **tmp;
>  
> -    tmp = g_malloc(0x20 * sizeof(opc_handler_t));
> +    tmp = g_new(opc_handler_t *, 0x20);
>      fill_new_table(tmp, 0x20);
>      table[idx] = (opc_handler_t *)((uintptr_t)tmp | PPC_INDIRECT);
>  

Reviewed-by: Tom Musta <tommusta@gmail.com>
Tested-by: Tom Musta <tommusta@gmail.com>