From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQIq8-0000rp-29 for qemu-devel@nongnu.org; Wed, 19 Mar 2014 11:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQIq2-0004SN-25 for qemu-devel@nongnu.org; Wed, 19 Mar 2014 11:55:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQIq1-0004SE-PW for qemu-devel@nongnu.org; Wed, 19 Mar 2014 11:55:29 -0400 Message-ID: <5329BDEA.3020902@redhat.com> Date: Wed, 19 Mar 2014 16:55:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395215937-22987-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1395215937-22987-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Andreas Faerber , Anthony Liguori Il 19/03/2014 08:58, Stefan Hajnoczi ha scritto: > [Due to a horrible accident, the subject line was chopped off while sending > this series. This is a resend, I have glued the subject line back on so patch > management tools can make sense of the series.] > > v4: > * Rebase to resolve merge conflicts > > v3: > * Split first commit for easier reviewing [afaerber] > * Turn bool argument into flags bitmask [pbonzini] > * Rename set() callback to check() [pbonzini] > * Rename object_property_default_set_link() to > object_property_allow_set_link() > * Rename qdev_prop_default_set_link() to > qdev_prop_allow_set_link_before_realize() > > v2: > * A NULL set() callback should make the property read-only > > There are two problems with QOM link properties: > > 1. There are refcount leaks in many object_property_add_link() callers. > 2. There is no way to prevent link properties from being set after a device is > realized. > > This patch series fixes these issues by extending the > object_property_add_link() function. > > Stefan Hajnoczi (5): > qom: split object_property_set_link() > qom: don't make link NULL on object_property_set_link() failure > qom: make QOM link property unref optional > qom: add check() argument to object_property_add_link() > virtio-rng: avoid default_backend refcount leak > > hw/core/qdev-properties.c | 12 ++++ > hw/core/qdev.c | 10 +++- > hw/dma/xilinx_axidma.c | 20 +++++-- > hw/net/xilinx_axienet.c | 20 +++++-- > hw/pcmcia/pxa2xx.c | 4 +- > hw/s390x/s390-virtio-bus.c | 4 +- > hw/s390x/virtio-ccw.c | 4 +- > hw/virtio/virtio-pci.c | 4 +- > hw/virtio/virtio-rng.c | 7 ++- > include/hw/qdev-properties.h | 11 ++++ > include/qom/object.h | 29 +++++++++- > qom/object.c | 130 ++++++++++++++++++++++++++++++++----------- > ui/console.c | 5 +- > 13 files changed, 211 insertions(+), 49 deletions(-) > Reviewed-by: Paolo Bonzini