From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQO1m-0000BL-7u
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:28:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQO1e-0003AC-Pr
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:27:58 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58350 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQO1e-0003A7-JC
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:27:50 -0400
Message-ID: <532A0BD4.7000802@suse.de>
Date: Wed, 19 Mar 2014 22:27:48 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1395215937-22987-1-git-send-email-stefanha@redhat.com>
	<1395215937-22987-5-git-send-email-stefanha@redhat.com>
In-Reply-To: <1395215937-22987-5-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to
 object_property_add_link()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>, Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

Am 19.03.2014 08:58, schrieb Stefan Hajnoczi:
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.=
h
> index 3c000ee..68aaed6 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -204,4 +204,15 @@ void qdev_property_add_static(DeviceState *dev, Pr=
operty *prop, Error **errp);
>   */
>  void qdev_prop_set_after_realize(DeviceState *dev, const char *name,
>                                   Error **errp);
> +
> +/**
> + * @qdev_prop_allow_set_link_before_realize:
> + *
> + * Set the Error object if an attempt is made to set the link after re=
alize.
> + * This function should be used as the check() argument to
> + * object_property_add_link().
> + */
> +void qdev_prop_allow_set_link_before_realize(Object *obj, const char *=
name,
> +                                             Object *val, Error **errp=
);
> +
>  #endif

This is copying a bad example ... no @ before function name, as done
correctly in object.h. Fixed.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg