From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQO2z-0001Bd-SI for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:29:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQO2u-0003oy-2c for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:29:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58369 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQO2t-0003on-Sj for qemu-devel@nongnu.org; Wed, 19 Mar 2014 17:29:08 -0400 Message-ID: <532A0C22.7050700@suse.de> Date: Wed, 19 Mar 2014 22:29:06 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1395215937-22987-1-git-send-email-stefanha@redhat.com> <5329BDEA.3020902@redhat.com> In-Reply-To: <5329BDEA.3020902@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori Am 19.03.2014 16:55, schrieb Paolo Bonzini: > Il 19/03/2014 08:58, Stefan Hajnoczi ha scritto: >> [Due to a horrible accident, the subject line was chopped off while >> sending >> this series. This is a resend, I have glued the subject line back on >> so patch >> management tools can make sense of the series.] >> >> v4: >> * Rebase to resolve merge conflicts >> >> v3: >> * Split first commit for easier reviewing [afaerber] >> * Turn bool argument into flags bitmask [pbonzini] >> * Rename set() callback to check() [pbonzini] >> * Rename object_property_default_set_link() to >> object_property_allow_set_link() >> * Rename qdev_prop_default_set_link() to >> qdev_prop_allow_set_link_before_realize() >> >> v2: >> * A NULL set() callback should make the property read-only >> >> There are two problems with QOM link properties: >> >> 1. There are refcount leaks in many object_property_add_link() callers= . >> 2. There is no way to prevent link properties from being set after a >> device is >> realized. >> >> This patch series fixes these issues by extending the >> object_property_add_link() function. >> >> Stefan Hajnoczi (5): >> qom: split object_property_set_link() >> qom: don't make link NULL on object_property_set_link() failure >> qom: make QOM link property unref optional >> qom: add check() argument to object_property_add_link() >> virtio-rng: avoid default_backend refcount leak >> >> hw/core/qdev-properties.c | 12 ++++ >> hw/core/qdev.c | 10 +++- >> hw/dma/xilinx_axidma.c | 20 +++++-- >> hw/net/xilinx_axienet.c | 20 +++++-- >> hw/pcmcia/pxa2xx.c | 4 +- >> hw/s390x/s390-virtio-bus.c | 4 +- >> hw/s390x/virtio-ccw.c | 4 +- >> hw/virtio/virtio-pci.c | 4 +- >> hw/virtio/virtio-rng.c | 7 ++- >> include/hw/qdev-properties.h | 11 ++++ >> include/qom/object.h | 29 +++++++++- >> qom/object.c | 130 >> ++++++++++++++++++++++++++++++++----------- >> ui/console.c | 5 +- >> 13 files changed, 211 insertions(+), 49 deletions(-) >> >=20 > Reviewed-by: Paolo Bonzini Thanks, applied to qom-next with two minor gtk-doc fixes: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg