From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQOwv-00017w-FS for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQOwp-0007dm-Lt for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:27:01 -0400 Received: from mout.gmx.net ([212.227.15.18]:53478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQOwp-0007dV-DP for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:26:55 -0400 Message-ID: <532A1A30.3040306@caramail.com> Date: Wed, 19 Mar 2014 23:29:04 +0100 From: Olivier Danet MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v2] sparc32 : Signed integer division overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Blue Swirl , Mark Cave-Ayland The signed integer division -0x8000_0000_0000_0000 / -1 must be handled separately to avoid an overflow on the QEMU host. Signed-off-by: Olivier Danet --- target-sparc/helper.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target-sparc/helper.c b/target-sparc/helper.c index f3c7fbf..3822c48 100644 --- a/target-sparc/helper.c +++ b/target-sparc/helper.c @@ -122,12 +122,15 @@ static target_ulong helper_sdiv_common(CPUSPARCState *env, target_ulong a, if (x1 == 0) { cpu_restore_state(CPU(cpu), GETPC()); helper_raise_exception(env, TT_DIV_ZERO); - } - - x0 = x0 / x1; - if ((int32_t) x0 != x0) { - x0 = x0 < 0 ? 0x80000000 : 0x7fffffff; + } else if (x1 == -1 && x0 == INT64_MIN) { + x0 = 0x7fffffff; overflow = 1; + } else { + x0 = x0 / x1; + if ((int32_t) x0 != x0) { + x0 = x0 < 0 ? 0x80000000 : 0x7fffffff; + overflow = 1; + } } if (cc) { -- 1.8.1.5