From: "Andreas Färber" <andreas.faerber@web.de>
To: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-ppc@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1
Date: Wed, 19 Mar 2014 23:47:19 +0100 [thread overview]
Message-ID: <532A1E77.6050000@web.de> (raw)
In-Reply-To: <CACXAS8AZzUeKqmv1cXDNSxezQsv85ZJgYVVtbNeDaA3V6OEPsw@mail.gmail.com>
Am 17.03.2014 22:55, schrieb Artyom Tarasenko:
> Hi Andreas,
>
> On Mon, Mar 17, 2014 at 8:59 PM, Andreas Färber <andreas.faerber@web.de> wrote:
>>> this patch seems still be missing in master. Is it causing any problems?
>>
>> It does not apply without the preceding patches. Here's my cherry-pick
>> result:
>> [...]
>> I.e. we might change 1 -> 4 in the SysBus API, but would that work given
>> that endianness is being changed alongside?
>
> Yes, and that's the point of this patch. PCI configuration space is
> little-endian. With 1 byte access size, no byte swapping happens, so
> the bug is hidden.
> But on 32- and 16- bit accesses the bytes are swapped.
I think you misunderstood my question: I wanted to know whether
switching from SysBus API to pure MemoryRegion API was part of the fix
or an independent cleanup. But now that I'm going through the respun
series it doesn't really matter any more...
Andreas
next prev parent reply other threads:[~2014-03-19 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 22:46 [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1 Artyom Tarasenko
2014-02-10 22:55 ` [Qemu-devel] [Qemu-ppc] " Mark Cave-Ayland
2014-02-11 23:32 ` Andreas Färber
2014-03-16 22:27 ` [Qemu-devel] " Artyom Tarasenko
2014-03-17 19:59 ` Andreas Färber
2014-03-17 21:55 ` Artyom Tarasenko
2014-03-17 22:25 ` Hervé Poussineau
2014-03-19 22:44 ` Andreas Färber
2014-03-17 22:28 ` Mark Cave-Ayland
2014-03-19 22:47 ` Andreas Färber [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-04 23:09 [Qemu-devel] [PATCH v3 00/10] prep: improve Raven PCI host emulation Hervé Poussineau
2013-11-04 23:09 ` [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1 Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A1E77.6050000@web.de \
--to=andreas.faerber@web.de \
--cc=atar4qemu@gmail.com \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).