From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WQPpF-00028U-BG
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 19:23:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WQPp8-0001hS-0d
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 19:23:09 -0400
Message-ID: <532A26A1.9060508@web.de>
Date: Thu, 20 Mar 2014 00:22:09 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1395093625-17470-1-git-send-email-hpoussin@reactos.org>
	<1395093625-17470-3-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1395093625-17470-3-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 2/7] raven: implement non-contiguous I/O
	region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

Am 17.03.2014 23:00, schrieb Hervé Poussineau:
> +static uint64_t raven_io_read(void *opaque, hwaddr addr,
> +                              unsigned int size)
> +{
> +    PREPPCIState *s = opaque;
> +    uint8_t buf[4];
> +
> +    addr = raven_io_address(s, addr);
> +    address_space_read(&s->pci_io_as, addr, buf, size);
> +
> +    if (size == 1) {
> +        return buf[0];
> +    } else if (size == 2) {
> +        return lduw_p(buf);
> +    } else if (size == 4) {
> +        return ldl_p(buf);
> +    } else {
> +        assert(false);
> +    }
> +}
> +
> +static void raven_io_write(void *opaque, hwaddr addr,
> +                           uint64_t val, unsigned int size)
> +{
> +    PREPPCIState *s = opaque;
> +    uint8_t buf[4];
> +
> +    addr = raven_io_address(s, addr);
> +
> +    if (size == 1) {
> +        buf[0] = val;
> +    } else if (size == 2) {
> +        stw_p(buf, val);
> +    } else if (size == 4) {
> +        stl_p(buf, val);
> +    } else {
> +        assert(false);

Replacing these two with g_assert_not_reached().

Regards,
Andreas