qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
	Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/3] spapr: fix H_SET_MODE
Date: Thu, 20 Mar 2014 01:21:19 +0100	[thread overview]
Message-ID: <532A347F.5000100@suse.de> (raw)
In-Reply-To: <1395273809-12809-1-git-send-email-aik@ozlabs.ru>

Am 20.03.2014 01:03, schrieb Alexey Kardashevskiy:
> This fixes H_SET_MODE.
> Changes:
> v5:
> * fixed code style
> 
> v4:
> * rebased on top of current ppc-next.
> * changed PPC2_ISA207S flag value
> 
> 
> Alexey Kardashevskiy (3):
>   target-ppc: introduce powerisa-207-server flag
>   spapr_hcall: fix little-endian resource handling in H_SET_MODE

Thanks, applied these two to my ppc-next:
https://github.com/afaerber/qemu-cpu/commits/ppc-next

>   spapr_hcall: add address-translation-mode-on-interrupt resource in
>     H_SET_MODE

This doesn't strike me as a bug fix worthy of -rc1? Does anything
severely break without it that would justify putting it in -rc2?

Also some additional reviewer would assure me there's been no oversight.

Regards,
Andreas

>  hw/ppc/spapr_hcall.c        | 67 +++++++++++++++++++++++++++++++++++++++------
>  include/hw/ppc/spapr.h      |  9 ++++--
>  target-ppc/cpu.h            |  4 +++
>  target-ppc/translate_init.c |  3 +-
>  4 files changed, 72 insertions(+), 11 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      parent reply	other threads:[~2014-03-20  0:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  0:03 [Qemu-devel] [PATCH v5 0/3] spapr: fix H_SET_MODE Alexey Kardashevskiy
2014-03-20  0:03 ` [Qemu-devel] [PATCH v5 1/3] target-ppc: introduce powerisa-207-server flag Alexey Kardashevskiy
2014-03-20  0:03 ` [Qemu-devel] [PATCH v5 2/3] spapr_hcall: fix little-endian resource handling in H_SET_MODE Alexey Kardashevskiy
2014-03-20  0:03 ` [Qemu-devel] [PATCH v5 3/3] spapr_hcall: add address-translation-mode-on-interrupt resource " Alexey Kardashevskiy
2014-03-20 13:15   ` Mike Day
2014-03-20  0:21 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532A347F.5000100@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).