From: "Andreas Färber" <afaerber@suse.de>
To: Anton Blanchard <anton@samba.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset
Date: Thu, 20 Mar 2014 02:08:18 +0100 [thread overview]
Message-ID: <532A3F82.7010308@suse.de> (raw)
In-Reply-To: <20140306150652.1fc1313b@kryten>
Am 06.03.2014 05:06, schrieb Anton Blanchard:
>
> Since an OS can set LPCR_ILE we must clear it during reset. Otherwise
> if we reset into an OS with a different endian we die when we take
> the first exception.
>
> This fixes an issue seen on both full emulation and KVM.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 93d02c1..4d45197 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -739,6 +739,8 @@ static void spapr_cpu_reset(void *opaque)
>
> env->spr[SPR_HIOR] = 0;
>
> + env->spr[SPR_LPCR] &= ~LPCR_ILE;
I guess this is superseded by the generalized SPR reset?
Regards,
Andreas
> +
> env->external_htab = (uint8_t *)spapr->htab;
> env->htab_base = -1;
> env->htab_mask = HTAB_SIZE(spapr) - 1;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-20 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 4:06 [Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset Anton Blanchard
2014-03-20 1:08 ` Andreas Färber [this message]
2014-03-20 2:57 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A3F82.7010308@suse.de \
--to=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=anton@samba.org \
--cc=gkurz@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).