From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQRTA-0006jp-AM
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 21:08:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQRT4-0008UB-As
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 21:08:28 -0400
Message-ID: <532A3F82.7010308@suse.de>
Date: Thu, 20 Mar 2014 02:08:18 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20140306150652.1fc1313b@kryten>
In-Reply-To: <20140306150652.1fc1313b@kryten>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anton Blanchard <anton@samba.org>, Alexey Kardashevskiy <aik@ozlabs.ru>, Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Am 06.03.2014 05:06, schrieb Anton Blanchard:
>=20
> Since an OS can set LPCR_ILE we must clear it during reset. Otherwise
> if we reset into an OS with a different endian we die when we take
> the first exception.
>=20
> This fixes an issue seen on both full emulation and KVM.
>=20
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>=20
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 93d02c1..4d45197 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -739,6 +739,8 @@ static void spapr_cpu_reset(void *opaque)
> =20
>      env->spr[SPR_HIOR] =3D 0;
> =20
> +    env->spr[SPR_LPCR] &=3D ~LPCR_ILE;

I guess this is superseded by the generalized SPR reset?

Regards,
Andreas

> +
>      env->external_htab =3D (uint8_t *)spapr->htab;
>      env->htab_base =3D -1;
>      env->htab_mask =3D HTAB_SIZE(spapr) - 1;
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg