From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQclY-0006KJ-GH for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:12:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQclT-0004EF-JR for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:12:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQclT-0004E6-Aw for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:12:07 -0400 Message-ID: <532ADF56.1090700@redhat.com> Date: Thu, 20 Mar 2014 06:30:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395042401-19291-1-git-send-email-famz@redhat.com> <1395042401-19291-9-git-send-email-famz@redhat.com> In-Reply-To: <1395042401-19291-9-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LqW2VtdcUtr3FtH5wiaur0sLvRioaiiVM" Subject: Re: [Qemu-devel] [PATCH v3 8/9] qmp: Add support of "dirty-bitmap" sync mode for drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Benoit Canet , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LqW2VtdcUtr3FtH5wiaur0sLvRioaiiVM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/17/2014 01:46 AM, Fam Zheng wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. >=20 > There are two bitmap use modes for sync=3Ddirty-bitmap: >=20 > - reset: backup job makes a copy of bitmap and resets the original > one. > - consume: backup job makes the original anonymous (invisible to user)= > and releases it after use. >=20 > Signed-off-by: Fam Zheng > --- > +++ b/qapi-schema.json > @@ -1532,7 +1532,7 @@ > # Since: 1.3 > ## > { 'enum': 'MirrorSyncMode', > - 'data': ['top', 'full', 'none'] } > + 'data': ['top', 'full', 'none', 'dirty-bitmap'] } dirty-bitmap needs documentation. > =20 > ## > # @BlockJobType: > @@ -1908,6 +1908,22 @@ > 'data': { 'device': 'str', 'name': 'str' } } > =20 > ## > +# @BitmapUseMode > +# > +# An enumeration that tells QEMU what operation to take when consuming= a bitmap > +# a new image file. s/bitmap/bitmap in/ > +# > +# @consume: QEMU should just consume the bitmap and release it after u= sing > +# > +# @reset: QEMU should keep an internal copy of the bitmap and reset th= e > +# dirty record from original one I'm not quite sure what these terms mean when reading this in isolation; reading the entire patch gives a better picture but I'm wondering if we could make these two descriptions carry a bit more information. > @@ -1058,8 +1058,9 @@ Arguments: > (json-string, optional) > - "sync": what parts of the disk image should be copied to the destina= tion; > possibilities include "full" for all the disk, "top" for only the se= ctors > - allocated in the topmost image, or "none" to only replicate new I/O > - (MirrorSyncMode). > + allocated in the topmost image, "dirty-bitmap" for only sync the dir= ty s/sync // > + sectors in the bitmap, or "none" to only replicate new I/O (MirrorSy= ncMode). > +- "bitmap": bitmap name to use for sync=3D=3Ddirty-bitmap > - "mode": whether and how QEMU should create a new image > (NewImageMode, optional, default 'absolute-paths') > - "speed": the maximum speed, in bytes per second (json-int, optional)= >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LqW2VtdcUtr3FtH5wiaur0sLvRioaiiVM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTKt9WAAoJEKeha0olJ0NqNo0IAJFxkHGxBZtUDz2Hp+uuX2lh IZMpOyi2pV/Lx3JXLawVJ5QSkw68qXzGkizTGbReIfM9VcK53T1rtE7r/WUN1YC3 n98NEcjdhYtC5mfRpKxtVoId716VDnD34JT02tbWxXyZ7A8OuKYkcFeXoAHzQ+rr ujIR5H+vcFBe4sV1pbkgEz1LGlPGNsGlqJ0y1qUSe6BgKzQ2PLg0JfDM1R1I4r1A S9GVTX5Zag21kCgSkO4FcxCrBEWzuTWKfZVT189Prg7zvDhPs9j+M+OcYQ82aUls 7ZthukU0ePJ9hI2kM4RnBGOuPCRXtuBX/RioMB+CGvd2/Jl7hX9SYjhLvAnnABw= =5yaq -----END PGP SIGNATURE----- --LqW2VtdcUtr3FtH5wiaur0sLvRioaiiVM--