From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQdCM-00023C-Vq for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQdCE-00058P-1m for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:39:54 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:43451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQdCD-00057z-Nh for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:39:45 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Mar 2014 13:39:43 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3C3A9219005E for ; Thu, 20 Mar 2014 13:39:35 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2KDdSNs1180118 for ; Thu, 20 Mar 2014 13:39:28 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2KDddRX009503 for ; Thu, 20 Mar 2014 07:39:39 -0600 Message-ID: <532AEF9A.2000004@de.ibm.com> Date: Thu, 20 Mar 2014 14:39:38 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1394719868-24312-1-git-send-email-stefanha@redhat.com> <1394719868-24312-14-git-send-email-stefanha@redhat.com> <53271A5B.9080906@de.ibm.com> <20140320101318.GA1936@stefanha-thinkpad.redhat.com> In-Reply-To: <20140320101318.GA1936@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace internal thread with IOThread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , qemu-devel@nongnu.org, Dominik Dingel , Jens Freimann , Anthony Liguori , Cornelia Huck On 20/03/14 11:13, Stefan Hajnoczi wrote: > On Mon, Mar 17, 2014 at 04:52:59PM +0100, Christian Borntraeger wrote: >> This causes the following bug during managedsave of s390 with a guest that has multiple disks with dataplane. >> >> (gdb) bt >> #0 object_deinit (type=0x0, obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:410 >> #1 object_finalize (data=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:424 >> #2 object_unref (obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:726 >> #3 0x000000008011da60 in object_property_del (obj=0x807e8d80, name=0x807e8d60 "virtio-blk", errp=) at /home/cborntra/REPOS/qemu/qom/object.c:783 >> #4 0x000000008011dc0e in object_property_del_child (errp=0x0, child=0x807e8750, obj=0x807e8d80) at /home/cborntra/REPOS/qemu/qom/object.c:386 >> #5 object_unparent (obj=0x807e8750) at /home/cborntra/REPOS/qemu/qom/object.c:403 >> #6 0x0000000080183898 in virtio_blk_data_plane_destroy (s=0x8088a750) at /home/cborntra/REPOS/qemu/hw/block/dataplane/virtio-blk.c:430 > > Are you able to reproduce this reliably? > > 198fd05c357afff22f0b0e02639937519ed49b1f should have fixed it. Yes, I agree this should fix it, but I cant no longer start my guest with > 1 dataplane device, (see the 2nd bug report) so I cant reproduce right now.