From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQdW2-0000R2-TR
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:00:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQdVx-0003kU-99
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:00:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43516 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WQdVw-0003fY-VA
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:00:09 -0400
Message-ID: <532AF463.1080704@suse.de>
Date: Thu, 20 Mar 2014 15:00:03 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1395296712-25274-1-git-send-email-sw@weilnetz.de>
	<1395296712-25274-6-git-send-email-sw@weilnetz.de>
In-Reply-To: <1395296712-25274-6-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific
 data types in common header files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

Am 20.03.2014 07:25, schrieb Stefan Weil:
> These header files are used by most QEMU source files. If they
> depend on windows.h, all those source files do so, too.
>=20
> All Windows specific data types which are replaced use identical
> definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG
> and CRITICAL_SECTION are replaced by the compatible types
> WinHandle, WinLong and WinCriticalSection.
>=20
> Add an explicit dependency on qemu/winapi.h for some files which need i=
t.
> These sources use the Windows API (see comment after include statement)
> and no longer get windows.h indirectly from other header files.
>=20
> A workaround which was added in the previous patch is no longer needed.
>=20
> Now 175 *.o files remain which still depend on windows.h.
>=20
> Cc: Anthony Liguori <aliguori@amazon.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Andreas F=C3=A4rber <afaerber@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

For the record, I'm okay with WinHandle. I thought someone had
objections against some struct, but seems I missed either a discussion
or a respin.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg