From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQe5y-0003zD-OM for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQe5s-0000Za-Pn for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:37:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQe5s-0000ZM-I2 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:37:16 -0400 Message-ID: <532AFD13.6040509@redhat.com> Date: Thu, 20 Mar 2014 15:37:07 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395324392-2142-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1395324392-2142-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Christian Borntraeger Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto: > Christian Borntraeger noticed that the naming of the > internal IOThread objects, which are created when the user does not specify an > IOThread explicitly, can result in collisions. > > These patches make the IOThread object nameless so it cannot cause collisions. > This is important when multiple dataplane devices are used simultaneously or > the user happened to choose a colliding name. > > Stefan Hajnoczi (2): > iothread: make IOThread struct definition public > dataplane: replace iothread object_add() with embedded instance > > hw/block/dataplane/virtio-blk.c | 31 ++++++++++++------------------- > include/sysemu/iothread.h | 12 +++++++++++- > iothread.c | 11 ----------- > 3 files changed, 23 insertions(+), 31 deletions(-) > Reviewed-by: Paolo Bonzini