From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance
Date: Thu, 20 Mar 2014 15:37:54 +0100 [thread overview]
Message-ID: <532AFD42.7030602@redhat.com> (raw)
In-Reply-To: <1395324392-2142-3-git-send-email-stefanha@redhat.com>
Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto:
> + object_initialize(&s->internal_iothread_obj,
> + sizeof(s->internal_iothread_obj),
> + TYPE_IOTHREAD);
> + user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
Perhaps you need an object_property_add_child here? Otherwise the link
points to an object without a canonical path. Can do it as a follow-up
though.
Paolo
next prev parent reply other threads:[~2014-03-20 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 14:06 [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision Stefan Hajnoczi
2014-03-20 14:06 ` [Qemu-devel] [PATCH for-2.0 1/2] iothread: make IOThread struct definition public Stefan Hajnoczi
2014-03-20 14:06 ` [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance Stefan Hajnoczi
2014-03-20 14:37 ` Paolo Bonzini [this message]
2014-03-21 8:43 ` Stefan Hajnoczi
2014-03-20 14:37 ` [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision Paolo Bonzini
2014-03-20 14:52 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AFD42.7030602@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).